Fixed up for release. #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentru
reviewed
Mar 22, 2019
adafruit_button.py
Outdated
| @@ -38,21 +38,50 @@ | |||
|
|
|||
| """ | |||
|
|
|||
| from micropython import const | |||
| import displayio | |||
| from adafruit_display_text.text_area import TextArea | |||
There was a problem hiding this comment.
adafruit_display_text should refer to Label, instead of TextArea (https://github.com/adafruit/Adafruit_CircuitPython_Display_Text/releases/tag/2.0.0)
ladyada
requested changes
Mar 22, 2019
adafruit_button.py
Outdated
| Defaults to RECT. | ||
| :param fill_color: The color to fill the button. Defaults to 0xFFFFFF. | ||
| :param outline_color: The color of the outline of the button. | ||
| :param label: The button label. Defaults to 0x0. |
There was a problem hiding this comment.
label is the button text that appears inside it, by default nothing is displayed
adafruit_button.py
Outdated
| if self.shadow: | ||
| self.group.append(self.shadow) | ||
| self.group.append(self.body) | ||
|
|
||
| if label and (label_color is not None): # button with text label | ||
| if label and (label_color is not None): # button with text label | ||
| if not label_font: | ||
| raise RuntimeError("Please provide label font") | ||
| dims = label_font.text_bounding_box(label) | ||
| if dims[2] >= width or dims[3] >= height: | ||
| raise RuntimeError("Button not large enough for label") | ||
| self.label = TextArea(label_font, text=label) |
There was a problem hiding this comment.
should be Label not TextArea, too
ladyada
approved these changes
Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.